Skip to content

Conversation

beccasaurus
Copy link
Contributor

@beccasaurus beccasaurus commented Aug 8, 2019

This reverts commit 1cf4d1f.

This reverts this merged PR:
#2323

I got a notification the tests failed after this was merged:

eta_snippets_test.py::test_translate_text FAILED                        [  6%]
beta_snippets_test.py::test_batch_translate_text PASSED                  [ 12%]
beta_snippets_test.py::test_detect_language PASSED                       [ 18%]
beta_snippets_test.py::test_list_languages PASSED                        [ 25%]
beta_snippets_test.py::test_list_languages_with_target PASSED            [ 31%]
beta_snippets_test.py::test_create_glossary PASSED                       [ 37%]
beta_snippets_test.py::test_get_glossary PASSED                          [ 43%]
beta_snippets_test.py::test_list_glossary PASSED                         [ 50%]
beta_snippets_test.py::test_translate_text_with_glossary PASSED          [ 56%]
beta_snippets_test.py::test_delete_glossary PASSED                       [ 62%]
quickstart_test.py::test_quickstart PASSED                               [ 68%]
snippets_test.py::test_detect_language PASSED                            [ 75%]
snippets_test.py::test_list_languages PASSED                             [ 81%]
snippets_test.py::test_list_languages_with_target PASSED                 [ 87%]
snippets_test.py::test_translate_text PASSED                             [ 93%]
snippets_test.py::test_translate_utf8 FAILED                             [100%]
=================================== FAILURES ===================================
_____________________________ test_translate_text ______________________________
Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/python-docs-samples/translate/cloud-client/beta_snippets_test.py", line 66, in test_translate_text
    assert 'Zdravo svet' in out
AssertionError: assert 'Zdravo svet' in 'Translated Text: translated_text: "Pozdrav svijetu"\n\n'
_____________________________ test_translate_utf8 ______________________________
Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/python-docs-samples/translate/cloud-client/snippets_test.py", line 49, in test_translate_utf8
    assert u'I like pineapples.' in out
AssertionError: assert 'I like pineapples.' in 'Text: 나는 파인애플을 좋아한다.\nTranslation: I like pineapple\nDetected source language: ko\n'
--------------------------- Captured stdout teardown ---------------------------
Deleted: projects/python-docs-samples-tests/locations/us-central1/glossaries/must-start-with-letters-21d8cbd4-ba2e-11e9-90a2-42010a140244
- generated xml file: /home/travis/build/GoogleCloudPlatform/python-docs-samples/translate/cloud-client/sponge_log.xml -
==================== 2 failed, 14 passed in 175.01 seconds =====================

The PR was green and therefore appeared safe to merge.

@nnegrey Any chance you could take a closer look w/ @ecrowdus?

In the meantime, this will revert the failing change, although it looks like a second translation test failed too 😕 ~ Use this PR if useful

@beccasaurus beccasaurus requested a review from nnegrey August 8, 2019 22:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
@nnegrey
Copy link
Contributor

nnegrey commented Aug 9, 2019

It looks like tests un-related to those reverted changes are failing

@crowdus
Copy link
Contributor

crowdus commented Aug 9, 2019

It looks like tests un-related to those reverted changes are failing

My PR's changes didn't cause any tests to fail; the tests were failing before I changed anything. I assumed that a Python2/Python3 distinction was causing them to fail for me locally, so I didn't mention it to anyone (which in retrospect I shouldn't have done). I'm also guessing that the product team changed something that changed the behavior of the API but Travis didn't catch it because it only builds for a PR, and this PR is the first time that anyone has changed the samples since their initial commit.

@nnegrey
Copy link
Contributor

nnegrey commented Aug 13, 2019

Going to close this as a separate PR has resolved these failing tests.

@nnegrey nnegrey closed this Aug 13, 2019
@nnegrey nnegrey deleted the revert-broken-translation-fix branch August 13, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants