Skip to content

Add DICOMweb retrieve instance/image and download them to machine #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Add DICOMweb retrieve instance/image and download them to machine #2331

merged 2 commits into from
Aug 13, 2019

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Aug 12, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after removing the string concatenation. Let me know if/when you want merged.

study_uid = '1.3.6.1.4.1.11129.5.5.111396399361969898205364400549799252857604'
series_uid = '1.3.6.1.4.1.11129.5.5.195628213694300498946760767481291263511724'
instance_uid = '1.3.6.1.4.1.11129.5.5.' + \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use format instead of string continuation:

instance_uid = '{}.{}'.format(
'1.3.6.1.4.1.11129.5.5',
'153751009835107614666834563294684339746480')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please merge when you can.

@gguuss gguuss merged commit 5f4a9c4 into GoogleCloudPlatform:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants