Skip to content

Conversation

cwxie-google
Copy link
Contributor

We changed our feature recently, which need a pubsub topic to create resource.

Update the all CRUD tests.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice job! Thank you for the quick resolution!

platform linux -- Python 3.6.8, pytest-5.2.1, py-1.8.0, pluggy-0.13.0 -- /usr/local/google/home/class/temp/python-docs-samples/.nox/py36-sample-firestore-cloud-client/bin/python3.6
cachedir: .pytest_cache
rootdir: /usr/local/google/home/class/temp/python-docs-samples, inifile: pytest.ini
plugins: flaky-3.6.1, cov-2.8.1
collected 53 items

snippets_test.py::test_quickstart_new_instance PASSED                                                                                                                                   [  1%]
snippets_test.py::test_quickstart_add_data_two PASSED                                                                                                                                   [  3%]
snippets_test.py::test_quickstart_get_collection PASSED                                                                                                                                 [  5%]
snippets_test.py::test_quickstart_add_data_one PASSED                                                                                                                                   [  7%]
snippets_test.py::test_add_from_dict PASSED                                                                                                                                             [  9%]
snippets_test.py::test_add_data_types PASSED                                                                                                                                            [ 11%]
snippets_test.py::test_add_example_data PASSED                                                                                                                                          [ 13%]
snippets_test.py::test_add_custom_class_with_id PASSED                                                                                                                                  [ 15%]
snippets_test.py::test_add_data_with_id PASSED                                                                                                                                          [ 16%]
snippets_test.py::test_add_custom_class_generated_id PASSED                                                                                                                             [ 18%]
snippets_test.py::test_add_new_doc PASSED                                                                                                                                               [ 20%]
snippets_test.py::test_get_simple_query PASSED                                                                                                                                          [ 22%]
snippets_test.py::test_array_contains_filter PASSED                                                                                                                                     [ 24%]
snippets_test.py::test_get_full_collection PASSED                                                                                                                                       [ 26%]
snippets_test.py::test_get_custom_class PASSED                                                                                                                                          [ 28%]
snippets_test.py::test_get_check_exists PASSED                                                                                                                                          [ 30%]
snippets_test.py::test_structure_subcollection_ref PASSED                                                                                                                               [ 32%]
snippets_test.py::test_structure_collection_ref PASSED                                                                                                                                  [ 33%]
snippets_test.py::test_structure_doc_ref_alternate PASSED                                                                                                                               [ 35%]
snippets_test.py::test_structure_doc_ref PASSED                                                                                                                                         [ 37%]
snippets_test.py::test_update_create_if_missing PASSED                                                                                                                                  [ 39%]
snippets_test.py::test_update_doc PASSED                                                                                                                                                [ 41%]
snippets_test.py::test_update_doc_array PASSED                                                                                                                                          [ 43%]
snippets_test.py::test_update_multiple PASSED                                                                                                                                           [ 45%]
snippets_test.py::test_update_server_timestamp PASSED                                                                                                                                   [ 47%]
snippets_test.py::test_update_data_transaction PASSED                                                                                                                                   [ 49%]
snippets_test.py::test_update_data_transaction_result PASSED                                                                                                                            [ 50%]
snippets_test.py::test_update_data_batch PASSED                                                                                                                                         [ 52%]
snippets_test.py::test_update_nested PASSED                                                                                                                                             [ 54%]
snippets_test.py::test_compound_query_example PASSED                                                                                                                                    [ 56%]
snippets_test.py::test_compound_query_valid_multi_clause PASSED                                                                                                                         [ 58%]
snippets_test.py::test_compound_query_simple PASSED                                                                                                                                     [ 60%]
snippets_test.py::test_compound_query_invalid_multi_field PASSED                                                                                                                        [ 62%]
snippets_test.py::test_compound_query_single_clause PASSED                                                                                                                              [ 64%]
snippets_test.py::test_compound_query_valid_single_field PASSED                                                                                                                         [ 66%]
snippets_test.py::test_order_simple_limit PASSED                                                                                                                                        [ 67%]
snippets_test.py::test_order_simple_limit_desc PASSED                                                                                                                                   [ 69%]
snippets_test.py::test_order_multiple PASSED                                                                                                                                            [ 71%]
snippets_test.py::test_order_where_limit PASSED                                                                                                                                         [ 73%]
snippets_test.py::test_order_where_invalid PASSED                                                                                                                                       [ 75%]
snippets_test.py::test_order_where_valid PASSED                                                                                                                                         [ 77%]
snippets_test.py::test_cursor_simple_start_at PASSED                                                                                                                                    [ 79%]
snippets_test.py::test_cursor_simple_end_at PASSED                                                                                                                                      [ 81%]
snippets_test.py::test_snapshot_cursors PASSED                                                                                                                                          [ 83%]
snippets_test.py::test_cursor_paginate PASSED                                                                                                                                           [ 84%]
snippets_test.py::test_cursor_multiple_conditions PASSED                                                                                                                                [ 86%]
snippets_test.py::test_delete_single_doc PASSED                                                                                                                                         [ 88%]
snippets_test.py::test_delete_field PASSED                                                                                                                                              [ 90%]
snippets_test.py::test_listen_document PASSED                                                                                                                                           [ 92%]
snippets_test.py::test_listen_multiple PASSED                                                                                                                                           [ 94%]
snippets_test.py::test_listen_for_changes PASSED                                                                                                                                        [ 96%]
snippets_test.py::test_delete_full_collection PASSED                                                                                                                                    [ 98%]
snippets_test.py::test_collection_group_query SKIPPED                                                                                                                                   [100%]

====================================================================================== warnings summary =======================================================================================
firestore/cloud-client/snippets_test.py::test_delete_full_collection
  /usr/local/google/home/class/temp/python-docs-samples/firestore/cloud-client/snippets.py:804: DeprecationWarning: 'Query.get' is deprecated:  please use 'Query.stream' instead.
    docs = coll_ref.limit(batch_size).get()

-- Docs: https://docs.pytest.org/en/latest/warnings.html
--------------------------------------- generated xml file: /usr/local/google/home/class/temp/python-docs-samples/firestore/cloud-client/sponge_log.xml ---------------------------------------
========================================================================= 52 passed, 1 skipped, 1 warnings in 24.38s ==========================================================================
nox > Session py36(sample='./firestore/cloud-client') was successful.

@gguuss gguuss merged commit c24be57 into GoogleCloudPlatform:master Oct 10, 2019
@gguuss
Copy link
Contributor

gguuss commented Oct 10, 2019

Looks like I ran the wrong tests :/

@gguuss
Copy link
Contributor

gguuss commented Oct 10, 2019

But they're still passing:

===================================================================================== test session starts =====================================================================================
platform linux -- Python 3.6.8, pytest-5.2.1, py-1.8.0, pluggy-0.13.0 -- /usr/local/google/home/class/temp/python-docs-samples/.nox/py36-sample-asset-cloud-client/bin/python3.6
cachedir: .pytest_cache
rootdir: /usr/local/google/home/class/temp/python-docs-samples, inifile: pytest.ini
plugins: flaky-3.6.1, cov-2.8.1
collected 7 items

quickstart_batchgetassetshistory_test.py::test_batch_get_assets_history PASSED                                                                                                          [ 14%]
quickstart_createfeed_test.py::test_create_feed PASSED                                                                                                                                  [ 28%]
quickstart_deletefeed_test.py::test_delete_feed PASSED                                                                                                                                  [ 42%]
quickstart_exportassets_test.py::test_export_assets PASSED                                                                                                                              [ 57%]
quickstart_getfeed_test.py::test_get_feed PASSED                                                                                                                                        [ 71%]
quickstart_listfeeds_test.py::test_list_feeds PASSED                                                                                                                                    [ 85%]
quickstart_updatefeed_test.py::test_update_feed PASSED                                                                                                                                  [100%]

----------------------------------------- generated xml file: /usr/local/google/home/class/temp/python-docs-samples/asset/cloud-client/sponge_log.xml -----------------------------------------
================================================================================ 7 passed in 154.17s (0:02:34) ================================================================================
nox > Session py36(sample='./asset/cloud-client') was successful.

arithmetic1728 pushed a commit to googleapis/python-asset that referenced this pull request Jul 31, 2020
…form/python-docs-samples#2467)

* Add Real Time Feed API Sample Code
* Update Real Time Feed API unit tests
busunkim96 pushed a commit to googleapis/python-asset that referenced this pull request Aug 4, 2020
…form/python-docs-samples#2467)

* Add Real Time Feed API Sample Code
* Update Real Time Feed API unit tests
engelke pushed a commit that referenced this pull request Nov 28, 2022
* Add Real Time Feed API Sample Code
* Update Real Time Feed API unit tests
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
* Add Real Time Feed API Sample Code
* Update Real Time Feed API unit tests
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
…form/python-docs-samples#2467)

* Add Real Time Feed API Sample Code
* Update Real Time Feed API unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants