IAM: re-add testing permissions #2494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding back tests that were accidentally removed in a previous commit
Update personal fork
|
@engelke Could you review this PR and merge if approved? |
engelke
reviewed
Oct 23, 2019
engelke
approved these changes
Oct 23, 2019
|
Thanks! Could you merge it also? I don't have permission to. |
|
Happy to. Done.
…On Wed, Oct 23, 2019 at 3:36 PM melaniedejong ***@***.***> wrote:
Thanks! Could you merge it also? I don't have permission to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2494?email_source=notifications&email_token=AAAT6N3ZDUEKT3HDU26EQYDQQDGV5A5CNFSM4JEJYR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECDC6FY#issuecomment-545664791>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT6N4DZMX2SBIRRW2M4JDQQDGV5ANCNFSM4JEJYR6Q>
.
--
Charles Engelke
GCP AppDev DPE
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_permissions method was deleted in a recent large-scale PR. This PR would add it back.