Skip to content

Fix pubsub topic name format #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix pubsub topic name format #2547

merged 1 commit into from
Nov 18, 2019

Conversation

engelke
Copy link
Contributor

@engelke engelke commented Nov 18, 2019

Apparently the patch API tolerated a bad format name until a few weeks ago, so this error was uncaught until now.

@engelke
Fix pubsub topic name format
7d85ae5 
Apparently the patch API tolerated a bad format name until a few weeks ago, so this error was uncaught until now.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
@engelke engelke requested a review from leahecole November 18, 2019 18:41
@leahecole
Copy link
Collaborator

That's what happens with a product in beta! Thanks for the quick fix :)

leahecole
leahecole approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 29207cb into master Nov 18, 2019
@engelke engelke deleted the fix-dicom-patch branch November 18, 2019 18:48
@leahecole leahecole mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engelke @leahecole @googlebot