Skip to content

Remove black from noxfile-template #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Remove black from noxfile-template #2593

merged 1 commit into from
Dec 10, 2019

Conversation

busunkim96
Copy link
Contributor

Removing black from lint check until we've had more discussion on what we'd like our style guide to be.

@busunkim96 busunkim96 requested a review from a team as a code owner December 10, 2019 20:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@gguuss
Copy link
Contributor

gguuss commented Dec 10, 2019

LGTM, thank you!

gguuss
gguuss approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@busunkim96
Copy link
Contributor Author

Squashing and merging as Leah is traveling all day and Kurtis is OOO. 😬 We should revisit permissions on this repo.

@busunkim96 busunkim96 merged commit cce0c9d into GoogleCloudPlatform:master Dec 10, 2019
@busunkim96 busunkim96 deleted the remove-black branch December 10, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dmahugh dmahugh

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @gguuss @dmahugh @googlebot