Skip to content

[Storage] Split samples #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 13, 2019
Merged

[Storage] Split samples #2602

merged 13 commits into from
Dec 13, 2019

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Dec 11, 2019 •
edited
Loading

Split Storage samples for usability which will include required imports to run samples.
I did not split sample tests.

@frankyn frankyn added the api: storage Issues related to the Cloud Storage API. label Dec 11, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
@frankyn frankyn added do not merge Indicates a pull request not ready for merge, due to either quality or timing. needs work This is a pull request that needs a little love. labels Dec 11, 2019
@frankyn frankyn marked this pull request as ready for review December 13, 2019 17:03
@frankyn frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 13, 2019
@frankyn frankyn requested a review from a team as a code owner December 13, 2019 17:03
@frankyn frankyn removed the needs work This is a pull request that needs a little love. label Dec 13, 2019
@frankyn frankyn changed the title [Storage] [WIP] Split samples [Storage] Split samples Dec 13, 2019
dmahugh
dmahugh approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@dmahugh dmahugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll figure out how to handle parallelization of tests later.

@frankyn frankyn merged commit 9e37c6f into master Dec 13, 2019
@frankyn frankyn deleted the split-samples branch December 13, 2019 21:17
@frankyn
Copy link
Contributor Author

frankyn commented Dec 13, 2019

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmahugh dmahugh dmahugh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frankyn @dmahugh @googlebot @busunkim96