Skip to content

dialogflow: split up entity and entity type tests #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 27, 2020
Merged

dialogflow: split up entity and entity type tests #2735

merged 5 commits into from
Jan 27, 2020

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Jan 17, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2020
@nnegrey nnegrey marked this pull request as ready for review January 27, 2020 20:40
@nnegrey nnegrey requested a review from a team as a code owner January 27, 2020 20:40
dmahugh
dmahugh approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@dmahugh dmahugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmahugh dmahugh merged commit e7ebcdc into master Jan 27, 2020
@dmahugh dmahugh deleted the dialogflow-entity-type branch January 27, 2020 20:47
busunkim96 pushed a commit to busunkim96/dialogflow-python-client-v2 that referenced this pull request Nov 30, 2020
@nnegrey
dialogflow: split up entity and entity type tests [(#2735)](GoogleClo…
53d660c 
…udPlatform/python-docs-samples#2735)

* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
busunkim96 pushed a commit to googleapis/python-dialogflow that referenced this pull request Dec 9, 2020
@nnegrey @busunkim96
dialogflow: split up entity and entity type tests [(#2735)](GoogleClo…
fc2eb04 
…udPlatform/python-docs-samples#2735)

* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
telpirion pushed a commit that referenced this pull request Jan 18, 2023
@nnegrey @busunkim96
dialogflow: split up entity and entity type tests [(#2735)](#2735)
ff2f90f 
* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
@telpirion telpirion mentioned this pull request Jan 18, 2023
Closed
8 tasks
@yil532 yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
@nnegrey @dandhlee
dialogflow: split up entity and entity type tests [(#2735)](#2735)
2911055 
* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@nnegrey @telpirion
dialogflow: split up entity and entity type tests [(#2735)](#2735)
1260d19 
* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
vchudnov-g pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
@nnegrey @busunkim96
dialogflow: split up entity and entity type tests [(#2735)](GoogleClo…
6dd655d 
…udPlatform/python-docs-samples#2735)

* dialogflow: split up entity and entity type tests

* delete old file

* run black on new files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmahugh dmahugh dmahugh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dmahugh dmahugh

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnegrey @dmahugh @googlebot