Skip to content

Conversation

texasmichelle
Copy link
Member

@texasmichelle texasmichelle commented Jan 29, 2020

Cherry-picked from tmp-generated-samples branch.

Add tests
Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition
Edit test video to 3 seconds from 35

nnegrey and others added 2 commits January 29, 2020 18:18
Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition
@texasmichelle texasmichelle requested review from dizcology and a team as code owners January 29, 2020 19:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@texasmichelle
Copy link
Member Author

Each version submits 16 requests, which exceeds standard quota of 60 when running in parallel. I submitted a request for additional quota.

@texasmichelle texasmichelle added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 30, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 30, 2020
@texasmichelle texasmichelle added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2020
@texasmichelle texasmichelle added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2020
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as @dizcology is okay with it, I'm okay with it. Thank you for figuring out what needed to happen with the quota

@dizcology dizcology merged commit 80cc4e5 into GoogleCloudPlatform:master Jan 31, 2020
@texasmichelle texasmichelle deleted the logo_recognition branch January 31, 2020 00:17
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
…oudPlatform/python-docs-samples#2755)

* Add auto-generated Logo Recognition Samples

* Add tests

Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition

* Edit test video to 3 seconds from 35

Reduce quota usage to allow for parallel tests
Retain longer version only for tests that require it

* Fix bug

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…oudPlatform/python-docs-samples#2755)

* Add auto-generated Logo Recognition Samples

* Add tests

Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition

* Edit test video to 3 seconds from 35

Reduce quota usage to allow for parallel tests
Retain longer version only for tests that require it

* Fix bug

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
dizcology pushed a commit that referenced this pull request Sep 11, 2023
* Add auto-generated Logo Recognition Samples

* Add tests

Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition

* Edit test video to 3 seconds from 35

Reduce quota usage to allow for parallel tests
Retain longer version only for tests that require it

* Fix bug

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
leahecole added a commit that referenced this pull request Sep 15, 2023
* Add auto-generated Logo Recognition Samples

* Add tests

Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition

* Edit test video to 3 seconds from 35

Reduce quota usage to allow for parallel tests
Retain longer version only for tests that require it

* Fix bug

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…oudPlatform/python-docs-samples#2755)

* Add auto-generated Logo Recognition Samples

* Add tests

Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition

* Edit test video to 3 seconds from 35

Reduce quota usage to allow for parallel tests
Retain longer version only for tests that require it

* Fix bug

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants