Skip to content

.kokoro: publish test log to Build Cop Bot #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2020
Merged

.kokoro: publish test log to Build Cop Bot #2775

merged 7 commits into from
Feb 10, 2020

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 5, 2020

The Build Cop Bot will open/close issues for failing/passing tests.

The Build Cop Bot will open/close issues for failing/passing tests.
@tbpg tbpg requested a review from a team as a code owner February 5, 2020 16:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@@ -90,6 +90,33 @@ for file in **/requirements.txt; do
nox -s "$RUN_TESTS_SESSION"
EXIT=$?

# If we're running system tests, send the test log to the Build Cop Bot.
# See https://github.com/googleapis/repo-automation-bots/tree/master/packages/buildcop.
if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"system-tests"* ]]; then
Copy link
Collaborator

@leahecole leahecole Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this system-tests something that's on the kokoro end or is it searching for it here?

If searching here, it won't find it - we restructured the kokoro config files to be broken down by python version and then into continuous, periodic, presubmit, and lint, unlike before when we had system tests by product

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Switched to continuous. Let me know if you'd prefer periodic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. They're all going to fail right away - we're slowly but surely resolving all failures within.

@leahecole leahecole assigned kurtisvg and unassigned crwilcox Feb 6, 2020
if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"continuous"* ]]; then
# Use the service account with access to the repo-automation-bots project.
gcloud auth activate-service-account --key-file $GOOGLE_APPLICATION_CREDENTIALS
gcloud config set project repo-automation-bots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use -project flag on the command below instead? Hopefully none of the samples are relying on gcloud to detect projects, but it might be safer to minimize side effects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Switched.

@tbpg tbpg merged commit 2b3daa3 into master Feb 10, 2020
@tbpg tbpg deleted the buildcop branch February 10, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants