Skip to content

Adds check for missing gateway ID on gateway commands #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 7, 2020
Merged

Adds check for missing gateway ID on gateway commands #2780

merged 6 commits into from
Feb 7, 2020

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Feb 6, 2020

Resolves this issue

@gguuss gguuss requested a review from a team as a code owner February 6, 2020 18:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@gguuss gguuss mentioned this pull request Feb 6, 2020
Closed
@gguuss gguuss added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2020
@gguuss gguuss added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2020
@gguuss
Copy link
Contributor Author

gguuss commented Feb 6, 2020 •
edited
Loading

Weird, I wonder why I'm seeing:

To https://github.com/googlecloudplatform/python-docs-samples
 ! [rejected]          iot-detect-mqtt-nogatewayid -> iot-detect-mqtt-nogatewayid (fetch first)
error: failed to push some refs to 'https://github.com/googlecloudplatform/python-docs-samples'
hint: Updates were rejected because the remote contains work that you do

@leahecole
Copy link
Collaborator

@gguuss probably because I stealthily merged master into this PR right after you opened it

@gguuss
Copy link
Contributor Author

gguuss commented Feb 6, 2020

@gguuss probably because I stealthily merged master into this PR right after you opened it

Perfect :) Can you review my CL :)

@leahecole leahecole requested a review from hongalex February 6, 2020 22:05
hongalex
hongalex approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gguuss gguuss merged commit fa341e4 into master Feb 7, 2020
@gguuss gguuss deleted the iot-detect-mqtt-nogatewayid branch February 7, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@hongalex hongalex hongalex approved these changes

Assignees

@crwilcox crwilcox

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudiot_mqtt_example.py - on_connect Connection Refused: not authorised
6 participants
@gguuss @leahecole @hongalex @crwilcox @googlebot @kokoro-team