Skip to content

remove misleading raise_for_status #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 5, 2020
Merged

remove misleading raise_for_status #2948

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3cf40a0
remove misleading raise_for_status
TAOXUY Feb 20, 2020
0df9b5e
print status also
TAOXUY Feb 20, 2020
2108171
Merge branch 'master' into raise_for_status
TAOXUY Feb 21, 2020
cdcd613
Merge branch 'master' into raise_for_status
TAOXUY Feb 26, 2020
78295ea
Merge branch 'master' into raise_for_status
leahecole Apr 17, 2020
da5e82a
Merge branch 'master' into raise_for_status
leahecole Apr 17, 2020
ac260f8
Merge branch 'master' into raise_for_status
TAOXUY Apr 22, 2020
46a2e9b
Merge branch 'master' into raise_for_status
TAOXUY Apr 29, 2020
62134e7
add raise for status
TAOXUY May 1, 2020
3a451ac
Merge branch 'raise_for_status' of github.com:TAOXUY/python-docs-samp…
TAOXUY May 1, 2020
a0a1a8e
Merge branch 'master' into raise_for_status
TAOXUY May 4, 2020
d5c8cce
Merge branch 'master' into raise_for_status
busunkim96 May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions endpoints/getting-started/clients/google-jwt-client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ def make_jwt_request(signed_jwt, url='https://your-endpoint.com'):
'content-type': 'application/json'
}
response = requests.get(url, headers=headers)

print(response.status_code, response.content)
response.raise_for_status()
return response.text

# [END endpoints_jwt_request]


Expand All @@ -96,4 +96,4 @@ def make_jwt_request(signed_jwt, url='https://your-endpoint.com'):
args.sa_email,
args.audience,
expiry_length)
print(make_jwt_request(keyfile_jwt, args.host))
make_jwt_request(keyfile_jwt, args.host)