Skip to content

Passing flaky hints to prevent buildcop failures #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2020
Merged

Passing flaky hints to prevent buildcop failures #2996

merged 4 commits into from
Feb 26, 2020

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Feb 26, 2020

No description provided.

@gguuss gguuss requested a review from a team as a code owner February 26, 2020 18:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@leahecole
Copy link
Collaborator

LGTM when tests pass, but I am not sure why it doesn't like the min_passes param. Let me know if you want to pair to try to debug.

@gguuss
Copy link
Contributor Author

gguuss commented Feb 26, 2020

I'm seeing:

 ! [rejected]          iot-extra-flaky -> iot-extra-flaky (fetch first)
error: failed to push some refs to 'https://github.com/googlecloudplatform/python-docs-samples'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@leahecole
Copy link
Collaborator

@gguuss it's because I merged master into this to keep it up to date and re-trigger the CI earlier :)

@leahecole leahecole merged commit 25107b8 into master Feb 26, 2020
@leahecole leahecole deleted the iot-extra-flaky branch February 26, 2020 19:56
@leahecole leahecole linked an issue Feb 26, 2020 that may be closed by this pull request
iot.api-client.mqtt_example.cloudiot_mqtt_example_test: test_gateway_trigger_error_topic failed #2862
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iot.api-client.mqtt_example.cloudiot_mqtt_example_test: test_gateway_trigger_error_topic failed
4 participants
@gguuss @leahecole @busunkim96 @googlebot