Skip to content

DO NOT MERGE vision: v1 logo detection samples #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

DO NOT MERGE vision: v1 logo detection samples #3094

wants to merge 3 commits into from

Conversation

czahedi
Copy link
Contributor

@czahedi czahedi commented Mar 12, 2020

v1 logo detection samples. Service not rolled out yet so DO NOT MERGE

@czahedi czahedi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2020
@czahedi czahedi requested a review from nnegrey March 12, 2020 18:57
@czahedi czahedi requested review from sirtorry and a team as code owners March 12, 2020 18:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
nnegrey
nnegrey reviewed Mar 12, 2020
View reviewed changes
video/cloud-client/analyze/video_detect_logo.py
@@ -14,16 +14,16 @@

import io

# [START video_detect_logo_beta]
# [START video_detect_logo]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we try not to do this as it will break docs. Prefer to create a new GA file rather than rename beta files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dang good point. Do we then follow up and delete the beta files?

@czahedi
Copy link
Contributor Author

czahedi commented Mar 12, 2020

Closing will rebase with appropriate names

@czahedi czahedi closed this Mar 12, 2020
@czahedi czahedi deleted the vision-v1-logo branch March 12, 2020 21:22
@czahedi czahedi mentioned this pull request Mar 12, 2020
Merged
@czahedi
Copy link
Contributor Author

czahedi commented Mar 12, 2020

See #3098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnegrey nnegrey nnegrey left review comments

@sirtorry sirtorry Awaiting requested review from sirtorry

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czahedi @nnegrey @googlebot @leahecole