Skip to content

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Mar 31, 2020

Fix: #3224
Fix: #3223
Fix: #3220

@nnegrey nnegrey requested review from sirtorry and a team as code owners March 31, 2020 15:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
Copy link
Contributor

@sirtorry sirtorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

@nnegrey
Copy link
Contributor Author

nnegrey commented Mar 31, 2020

Different test is failing, which has been untouched so I need to go figure out why it now has an invalid argument. Possibly a change in the beta? Investigating.

@nnegrey nnegrey added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Mar 31, 2020
@nnegrey
Copy link
Contributor Author

nnegrey commented Mar 31, 2020

Well turns out we don't even have tests for local files across the board. :O

@nnegrey
Copy link
Contributor Author

nnegrey commented Mar 31, 2020

I think the cat video is corrupted. As each time I use that video, it fails. But I tried another and it works...

@nnegrey nnegrey requested a review from telpirion as a code owner April 1, 2020 14:07
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super small nit, otherwise LGTM.

@nnegrey nnegrey removed the status: investigating The issue is under investigation, which is determined to be non-trivial. label Apr 2, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 7, 2020

Thanks @nnegrey for the fix. I'll merge once the tests pass

@tmatsuo tmatsuo merged commit c676778 into master Apr 7, 2020
@tmatsuo tmatsuo deleted the fix-video-tests branch April 7, 2020 23:11
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
…-samples#3235)

* video: fix flaky beta tests

* fix failing test with new video file

* add local file tests

* update test

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…-samples#3235)

* video: fix flaky beta tests

* fix failing test with new video file

* add local file tests

* update test

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
dizcology pushed a commit that referenced this pull request Sep 11, 2023
* video: fix flaky beta tests

* fix failing test with new video file

* add local file tests

* update test

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
leahecole pushed a commit that referenced this pull request Sep 15, 2023
* video: fix flaky beta tests

* fix failing test with new video file

* add local file tests

* update test

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…-samples#3235)

* video: fix flaky beta tests

* fix failing test with new video file

* add local file tests

* update test

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
6 participants