Skip to content

Conversation

theacodes
Copy link
Contributor

No description provided.

Change-Id: I4e2c41f0b522d4ca2a9d1ea15e705d86d640936b
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2016
os.environ.get('TRAVIS_COMMIT'),
os.environ.get('TRAVIS_BRANCH')])
else:
changed = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe raise since this should never happen?

Copy link
Contributor Author

@theacodes theacodes May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, I want to keep an eye on this first.

@waprin
Copy link
Contributor

waprin commented May 5, 2016

code lgtm...i feel like some of the nox.py could be refactored to be a bit more declarative but im still thinking out how.

@theacodes
Copy link
Contributor Author

Yeah, I cleaned it up a bit this round, but I'm wondering how much more we could clean it and how much of this we could shove in to repo-tools.

@theacodes theacodes merged commit 5d78296 into master May 5, 2016
@theacodes theacodes deleted the travis-experiments branch May 5, 2016 18:30
donmccasland pushed a commit that referenced this pull request Nov 11, 2022
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
Source-Link: googleapis/synthtool@6fab84a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe
telpirion pushed a commit that referenced this pull request Jan 13, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee pushed a commit that referenced this pull request Jan 26, 2023
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Linchin pushed a commit that referenced this pull request Aug 18, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants