[iam] fix: reuse the same custom role for read/update tests #3291
Conversation
fixes GoogleCloudPlatform#2885 fixes GoogleCloudPlatform#2886 This PR will reduce the number of temporary custom roles to half. Not a fundamental fix, but it will definitely mitigate the above issues.
| except googleapiclient.errors.HttpError: | ||
| print("Custom role already deleted.") | ||
|
|
||
| # Ignore error since we just reuse the same custom role. |
There was a problem hiding this comment.
Can we make sure that we are ignoring the right error? Perhaps verify the message is correct and the snippet isn't failing for another reason?
There was a problem hiding this comment.
Sure! I'll make a change
|
@kurtisvg @leahecole PTAL |
|
lol the other test failed. I filed #3292 This is unreleated, so I'll just re-run the test. |
|
Ironically we reached the 300 limit because of the lots of builds due to PRs for fixing this very issue. I think we need to only run create/delete tests (which consume the quota) in the nightly builds. I'll add some changes for it in this PR later today. |
|
Still getting "Maximum number of roles reached. Maximum is: 300" More flakes I fixed, less likely this test will pass ... |
|
@leahecole Now the test passes! I addressed your comment, so I'm going to dismiss your review and merge this because it's a great chance :) |
I addressed your comment, also the test passes now!
fixes #2885
fixes #2886
This PR will reduce the number of temporary custom roles to half.
Not a fundamental fix, but it will definitely mitigate the above issues.