Skip to content

[iot] fix: use fixtures for resource setup/teardown #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2020
Merged

[iot] fix: use fixtures for resource setup/teardown #3428

merged 4 commits into from
Apr 21, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 17, 2020 •
edited
Loading

fixes #2861
fixes #3323

I also think:
fixes #2859
fixes #2860

@tmatsuo tmatsuo requested review from gguuss and kurtisvg April 17, 2020 23:52
@tmatsuo tmatsuo requested a review from a team as a code owner April 17, 2020 23:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 19, 2020

The topic name is very likely conflicting.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 19, 2020

Ha! The image test is failing for the same reason.

refactored out the fixtures
b6686e2 
* share the fixtures within two tests
* correct dependencies between fixtures
* use threading for cordinating between background and foreground
  threads.
gguuss
gguuss approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 21, 2020

Since we got approval from the product owner, I'm going to merge this with the admin power.

@tmatsuo tmatsuo merged commit e2cf90d into GoogleCloudPlatform:master Apr 21, 2020
@tmatsuo tmatsuo deleted the fix-iot branch April 21, 2020 00:54
@tmatsuo tmatsuo mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@tmatsuo @gguuss @googlebot