Skip to content

Adding test for taskqueue pull worker. Fixes #254 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2016
Merged

Adding test for taskqueue pull worker. Fixes #254 #349

merged 1 commit into from
May 16, 2016

Conversation

theacodes
Copy link
Contributor

No description provided.

Adding test for taskqueue pull worker. Fixes #254
d82d774 
Change-Id: I65d943bd0ecba1251d46e1d028722bbf685e0251
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2016
jerjou
jerjou reviewed May 16, 2016
View reviewed changes
appengine/taskqueue/pull-counter/pullcounter_test.py
@@ -31,3 +32,11 @@ def test_app(testbed):
tasks = tq_stub.get_filtered_tasks()
assert len(tasks) == 1
assert tasks[0].name == 'task1'

with mock.patch('main.update_counter') as mock_update:
# Force update to fail, otherwise the loop will go forever.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing some context, but is it not weird to have a worker that polls indefinitely? I'd expect a cron job or something instead, which you can at least cancel?

@jerjou
Copy link
Contributor

jerjou commented May 16, 2016

LGTM

@waprin
Copy link
Contributor

waprin commented May 16, 2016

lgtm

@theacodes
Copy link
Contributor Author

Travis is being exceptionally slow today. I verified locally.

@theacodes theacodes merged commit 48f9559 into master May 16, 2016
@theacodes theacodes deleted the taskqueue-tests branch May 16, 2016 20:07
@rsamborski rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@renovate-bot @rsamborski
chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)
ced8c17
donmccasland pushed a commit that referenced this pull request Nov 8, 2022
@renovate-bot
chore(deps): update dependency google-auth to v2.13.0 (#349)
335977b
@donmccasland donmccasland mentioned this pull request Nov 8, 2022
Merged
8 tasks
engelke pushed a commit that referenced this pull request Nov 9, 2022
@renovate-bot
chore(deps): update dependency google-crc32c to v1.5.0 (#349)
4e552d5
dandhlee pushed a commit that referenced this pull request Nov 9, 2022
@renovate-bot @dandhlee
chore(deps): update dependency google-auth to v2.13.0 (#349)
a97fd39
m-strzelczyk added a commit that referenced this pull request Nov 9, 2022
@m-strzelczyk
docs(samples): Fixing an issue with listing all instances (#349)
7e0f35b
@m-strzelczyk m-strzelczyk mentioned this pull request Nov 9, 2022
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot @dandhlee
chore(deps): update dependency google-crc32c to v1.5.0 (#349)
e524224
donmccasland pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot @parthea
fix: require python 3.7+ (#349)
ff62ae4 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@donmccasland donmccasland mentioned this pull request Nov 11, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot @rsamborski
chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)
fd771de
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot @rsamborski
chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)
74d51f2
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot @parthea
chore(deps): update dependency google-cloud-dataproc to v3.3.0 (#349)
09a6156 
* chore(deps): update dependency google-cloud-dataproc to v3.3.0

* remove pin for python 3.6

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@msampathkumar msampathkumar mentioned this pull request Nov 14, 2022
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot @dandhlee
chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)
9c2d084
dandhlee pushed a commit that referenced this pull request Nov 16, 2022
@m-strzelczyk @dandhlee
docs(samples): Fixing an issue with listing all instances (#349)
385995b
@telpirion telpirion mentioned this pull request Nov 16, 2022
Merged
8 tasks
telpirion pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot @parthea
chore: Adding support for pytest-xdist and pytest-parallel (#349)
6a3c613 
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
arbrown pushed a commit that referenced this pull request Nov 17, 2022
@gcf-owl-bot @parthea
chore: Adding support for pytest-xdist and pytest-parallel (#349)
f5d0e1e 
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@arbrown arbrown mentioned this pull request Nov 17, 2022
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
@gcf-owl-bot @parthea @dandhlee
chore: Adding support for pytest-xdist and pytest-parallel (#349)
2358caf 
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
@gcf-owl-bot @parthea @dandhlee
chore: Adding support for pytest-xdist and pytest-parallel (#349)
bb6433f 
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Jan 26, 2023
@gcf-owl-bot @parthea @dandhlee
fix: require python 3.7+ (#349)
787b839 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@gcf-owl-bot @parthea @telpirion
fix: require python 3.7+ (#349)
7996f05 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@waprin waprin

Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theacodes @jerjou @waprin @googlebot