Add region tags to bigtable/hello sample. #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from gcloud import bigtable | ||
| from gcloud.bigtable import happybase | ||
|
|
||
|
|
||
| def main(project, cluster_id, zone, table_name): | ||
| # [START connecting_to_bigtable] | ||
| # project = "my-project-id" |
There was a problem hiding this comment.
These comments are unnecessary.
There was a problem hiding this comment.
I agree w/ Jon - rename project => projectId (or the Python convention), same for the others.
There was a problem hiding this comment.
Unnecessary comments removed and project renamed to project_id.
|
LGTM with small nit, but @waprin should review. |
|
LGTM - w/ Jon's nit. |
Also, change the sample to use sequential keys (with a disclaimer) to match the Java sample. I had forgotten to add a sample usage to get a specific row, so add that, too.
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 13, 2023
* fix: warning message * docs: correct naming Co-authored-by: Yvonne <liyvonne@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Feb 9, 2023
* fix: warning message * docs: correct naming Co-authored-by: Yvonne <liyvonne@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* fix: warning message * docs: correct naming Co-authored-by: Yvonne <liyvonne@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, change the sample to use sequential keys (with a disclaimer) to
match the Java sample. I had forgotten to add a sample usage to get a
specific row, so add that, too.