Skip to content

[vision] chore: parameterized FROM, add cloudbuild.yaml #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2020
Merged

[vision] chore: parameterized FROM, add cloudbuild.yaml #3842

merged 4 commits into from
May 20, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented May 20, 2020

also update README with how to build and upload the images.

@genquan9
Now the images are little bit more maintenable. Potentially we can parameterize the version number too.

@tmatsuo tmatsuo requested review from sirtorry, telpirion and a team as code owners May 20, 2020 02:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
genquan9
genquan9 reviewed May 20, 2020
View reviewed changes
genquan9
genquan9 reviewed May 20, 2020
View reviewed changes
genquan9
genquan9 approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the codes following the comments? Thanks!

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 20, 2020

@genquan9 PTAL

For a record, if we want to update the tensorflow image version, you can do something like the following:

gawk -i inplace '{ gsub(/1.14.0/, "1.15.0") }; { print }' *

@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 20, 2020

The error message: "Error response from daemon: client version 1.40 is too new. Maximum supported API version is 1.38"

I'll add an env var to fix it.

@tmatsuo tmatsuo merged commit c21700f into GoogleCloudPlatform:master May 20, 2020
@tmatsuo tmatsuo deleted the vision branch May 20, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

1 more reviewer

@genquan9 genquan9 genquan9 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmatsuo @genquan9 @gguuss @googlebot