Skip to content

testing: diff against the common commit on the master #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2020
Merged

testing: diff against the common commit on the master #3916

merged 3 commits into from
May 30, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented May 29, 2020

This change allows us to only run necessary tests for Pull Requests.

@tmatsuo tmatsuo requested a review from a team as a code owner May 29, 2020 23:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2020
@tmatsuo tmatsuo requested a review from kurtisvg May 29, 2020 23:12
@tmatsuo tmatsuo mentioned this pull request May 29, 2020
Closed
kurtisvg
kurtisvg approved these changes May 30, 2020
View reviewed changes
@tmatsuo tmatsuo force-pushed the diff-from-common-commit branch from 23791cb to 7f89d3d Compare May 30, 2020 03:01
@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 30, 2020

The only failures on py-3.7 are dlp and firestore (503). I'm going to merge this.

@tmatsuo tmatsuo merged commit f0b1646 into GoogleCloudPlatform:master May 30, 2020
@tmatsuo tmatsuo deleted the diff-from-common-commit branch May 30, 2020 07:50
@tmatsuo tmatsuo mentioned this pull request May 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmatsuo @kurtisvg @googlebot @busunkim96