Skip to content

Add Datastore eventual consistency read example #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

Add Datastore eventual consistency read example #3976

merged 2 commits into from
Jun 5, 2020

Conversation

sdlin
Copy link
Contributor

@sdlin sdlin commented Jun 5, 2020

This snippet shows up here:
https://cloud.google.com/datastore/docs/concepts/structuring_for_strong_consistency#datastore-datastore-eventual-consistent-query-python

The eventual parameter is specified in the docs:
https://googleapis.dev/python/datastore/latest/queries.html

To check this, I ran the snippet:

>>> from google.cloud import datastore
>>> client = datastore.Client()
>>> query = client.query(kind='Task')
>>> query.fetch(eventual=True)
<google.cloud.datastore.query.Iterator object at 0x1023a2860>
>>> query.fetch()
<google.cloud.datastore.query.Iterator object at 0x1023a28d0>

@sdlin sdlin requested a review from a team as a code owner June 5, 2020 18:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@busunkim96
Copy link
Contributor

Could someone from @GoogleCloudPlatform/firestore-dpe take a quick look?

@busunkim96 busunkim96 requested a review from BenWhitehead June 5, 2020 20:13
BenWhitehead
BenWhitehead approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdlin!

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@sdlin
Copy link
Contributor Author

sdlin commented Jun 5, 2020 •
edited
Loading

The test failure is unrelated to this PR's change. The failure is in the cleanup path of a some test.

@tmatsuo tmatsuo merged commit 1cb0963 into GoogleCloudPlatform:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

+1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sdlin @busunkim96 @BenWhitehead @tmatsuo @gguuss @googlebot @kokoro-team