Skip to content

Rename DLP code samples from 'redact' to 'replace' #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2020
Merged

Rename DLP code samples from 'redact' to 'replace' #4020

merged 9 commits into from
Jun 9, 2020

Conversation

jlmwise
Copy link
Contributor

@jlmwise jlmwise commented Jun 9, 2020

In the DLP API, redaction and replacement are two separate, named concepts. Code samples recently added by #3964 were named 'redact' but are actually examples of replacement. This change renames those samples for clarity.

@jlmwise jlmwise requested a review from a team as a code owner June 9, 2020 01:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
busunkim96
busunkim96 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If these were published to devsite removing the existing region tags will break the include statements,

@jlmwise
Copy link
Contributor Author

jlmwise commented Jun 9, 2020

Thanks - the author of the first pull request hasn't added the region tags to the documentation yet.

@jlmwise
Copy link
Contributor Author

jlmwise commented Jun 9, 2020 •
edited
Loading

Can a reviewer merge this PR?

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 21a25b9 into GoogleCloudPlatform:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kurtisvg kurtisvg

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlmwise @busunkim96 @kurtisvg @googlebot @kokoro-team