Skip to content

Added tests for Django samples #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Jun 13, 2020

Description

Fixes #2574.

Note: It's a good idea to open an issue first for discussion.

Checklist

@michaelawyu michaelawyu requested a review from a team as a code owner June 13, 2020 02:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2020
@michaelawyu michaelawyu added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2020
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -0,0 +1,2 @@
[pytest]
DJANGO_SETTINGS_MODULE=mysite.settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. The noxfile in appengine/standard doesn't use noxfile_config.py. I'll take care of this with another PR.

@tmatsuo tmatsuo merged commit 2bc61a2 into master Jun 15, 2020
@tmatsuo tmatsuo deleted the michaelawyu-patch-django-test branch June 15, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appengine django examples don't have ci/cd tests
4 participants