Skip to content

functions: add missing integration test samples #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2020
Merged

functions: add missing integration test samples #4324

merged 4 commits into from
Jul 20, 2020

Conversation

ace-n
Copy link

@ace-n ace-n commented Jul 17, 2020

(The storage integration test will be added in #4305)

@ace-n ace-n requested a review from a team as a code owner July 17, 2020 22:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
engelke
engelke approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke self-requested a review July 17, 2020 22:57
@engelke
Copy link
Contributor

engelke commented Jul 17, 2020

Fix imports per lint. Otherwise LGTM.

@ace-n ace-n requested a review from a team July 18, 2020 03:45
@ace-n ace-n merged commit ee130dc into master Jul 20, 2020
@ace-n ace-n deleted the new-tests branch July 20, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke Awaiting requested review from engelke

1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@engelke engelke

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @engelke @grant