Skip to content

testing(run): use correct envvars #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

testing(run): use correct envvars #4450

merged 1 commit into from
Aug 6, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Aug 6, 2020

there are some GCLOUD_PROJECT leftovers

fixes #4449

testing(run): use correct envvars
0be100e 
there are some GCLOUD_PROJECT leftovers
@tmatsuo tmatsuo requested review from averikitsch, grant and a team as code owners August 6, 2020 19:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2020
@tmatsuo tmatsuo requested a review from dinagraves August 6, 2020 19:44
@busunkim96 busunkim96 merged commit 9fecf4a into GoogleCloudPlatform:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch

@grant grant Awaiting requested review from grant

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees

@crwilcox crwilcox

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests are failing with missing GCLOUD_PROJECT env var
4 participants
@tmatsuo @busunkim96 @kurtisvg @crwilcox