Skip to content

fix: use enums instead of str for task creation #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2020
Merged

fix: use enums instead of str for task creation #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bff7ba
fix: use enums instead of str
busunkim96 Sep 10, 2020
081336a
fix: fix create_task
busunkim96 Sep 10, 2020
66d7ccf
Merge branch 'master' into fix-appengine-tasks
gcf-merge-on-green[bot] Sep 10, 2020
bbd8344
Merge branch 'master' into fix-appengine-tasks
gcf-merge-on-green[bot] Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/flexible/tasks/create_app_engine_queue_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def create_task(project, queue, location, payload=None, in_seconds=None):
# Construct the request body.
task = {
'app_engine_http_request': { # Specify the type of request.
'http_method': 'POST',
'http_method': tasks_v2.HttpMethod.POST,
'relative_uri': '/example_task_handler'
}
}
Expand Down
8 changes: 4 additions & 4 deletions appengine/flexible/tasks/snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def create_task(project, location, queue):

task = {
'app_engine_http_request': {
'http_method': 'POST',
'http_method': tasks.HttpMethod.POST,
'relative_uri': '/update_counter',
'app_engine_routing': {
'service': 'worker'
Expand Down Expand Up @@ -120,7 +120,7 @@ def create_tasks_with_data(project, location, queue):

task1 = {
'app_engine_http_request': {
'http_method': 'POST',
'http_method': tasks.HttpMethod.POST,
'relative_uri': '/update_counter?key=blue',
'app_engine_routing': {
'service': 'worker'
Expand All @@ -130,7 +130,7 @@ def create_tasks_with_data(project, location, queue):

task2 = {
'app_engine_http_request': {
'http_method': 'POST',
'http_method': tasks.HttpMethod.POST,
'relative_uri': '/update_counter',
'app_engine_routing': {
'service': 'worker'
Expand Down Expand Up @@ -165,7 +165,7 @@ def create_task_with_name(project, location, queue, task_name):
task = {
'name': client.task_path(project, location, queue, task_name),
'app_engine_http_request': {
'http_method': 'GET',
'http_method': tasks.HttpMethod.GET,
'relative_uri': '/url/path'
}
}
Expand Down