Skip to content

refactor: remove spanner samples #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

refactor: remove spanner samples #4801

merged 1 commit into from
Oct 7, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Oct 6, 2020 •
edited
Loading

This PR removes the Cloud Spanner code samples as they have been moved to https://github.com/googleapis/python-spanner/tree/master/samples/samples

All documentation now points to the new location.

Closes #4756

@larkee larkee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: spanner Issues related to the Spanner API. labels Oct 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
@larkee larkee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 6, 2020
@larkee larkee marked this pull request as ready for review October 6, 2020 01:54
@larkee larkee requested a review from a team as a code owner October 6, 2020 01:54
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 6, 2020
@busunkim96 busunkim96 merged commit be2f491 into GoogleCloudPlatform:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner.cloud-client.backup_sample_test: test_list_backup_operations failed
2 participants
@larkee @busunkim96