Skip to content

chore: fixes flaky test #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2020
Merged

chore: fixes flaky test #4815

merged 3 commits into from
Oct 6, 2020
+0 −2

Conversation

danoscarmike
Copy link
Contributor

Fixes #4794

@danoscarmike danoscarmike requested a review from telpirion October 6, 2020 18:00
@danoscarmike danoscarmike requested review from sirtorry and a team as code owners October 6, 2020 18:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
leahecole
leahecole approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES. Thank you! I was just looking at test failures caused by this.

@leahecole leahecole mentioned this pull request Oct 6, 2020
Merged
1 task
@danoscarmike
chore: fixes flaky test
fd9caa0 
Fixes #4793
Removes assertion which the backend inconsistently satifies.
@danoscarmike
Merge branch 'master' into flaky-vid
041ff0e
@danoscarmike danoscarmike merged commit 1264ce6 into master Oct 6, 2020
@danoscarmike danoscarmike deleted the flaky-vid branch October 6, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@telpirion telpirion Awaiting requested review from telpirion

@sirtorry sirtorry Awaiting requested review from sirtorry

+1 more reviewer

@tmatsuo tmatsuo tmatsuo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

video.cloud-client.analyze.video_detect_faces_beta_test: test_detect_faces failed
3 participants
@danoscarmike @tmatsuo @leahecole