Skip to content

chore(Dockerfile): support PyPI packages with C bindings #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 28, 2020
Merged

chore(Dockerfile): support PyPI packages with C bindings #4898

merged 7 commits into from
Oct 28, 2020

Conversation

ace-n
Copy link

@ace-n ace-n commented Oct 23, 2020

Please merge for me once approved. Thanks!

@ace-n ace-n requested a review from a team as a code owner October 23, 2020 00:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
@ace-n ace-n mentioned this pull request Oct 23, 2020
Merged
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 23, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 24, 2020
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2020
@ace-n
Copy link
Author

ace-n commented Oct 25, 2020

Looks like the Python 3.7 build timed out (no idea why...does it deploy GAE flex samples?). @shubha-rajan @busunkim96 clear to merge as-is?

@busunkim96
Copy link
Contributor

Various builds are failing b/c of flakes unrelated to the Dockerfile change. Hammer merging.

@busunkim96 busunkim96 merged commit 07bcd07 into master Oct 28, 2020
@busunkim96 busunkim96 deleted the ace-n-patch-2 branch October 28, 2020 21:56
craiglabenz pushed a commit that referenced this pull request Nov 2, 2020
@craiglabenz
chore(Dockerfile): support PyPI packages with C bindings (#4898)
60cdb81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@shubha-rajan shubha-rajan shubha-rajan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@engelke engelke

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ace-n @busunkim96 @shubha-rajan @engelke @kokoro-team