-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(Dockerfile): add Python 3.9 #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unrelated note: it looks like we're running the Maybe we should reconsider that, since those builds tend to take awhile + consume lots of CI resources? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once other comments are addressed.
FYI looks like the failures were caused by a flaky Cloud Trace test? 🤔 |
FYI, kokoro configs submitted in g3. To be honest, I still expect failures on py-3.9 builds, likely because some APIs need to be enabled. |
FYI, I see lots of |
I updated the @leahecole @rafalbiegacz can one of you confirm that this is OK, or if I should revert? |
Failures in 3.9 build seem unrelated. Python folks - please merge this for me if you think it's good to go. Thanks! |
Python 3.9 build still has failing tests. Some are expected (need to enable APIs), some are unexpected. |
Failing to compile pylibmc, saying Update: Maybe I can install libmemcached-dev.
|
Probably we should skip them in py-3.9 build. Currently it says:
I think we need to update |
It seems like pip could not find google-python-cloud-debugger package:
Update: Probably we can skip this test for now, related: GoogleCloudPlatform/cloud-debug-python#22 |
Update: Maybe I can try installing liblapack-dev and libblas-dev. |
The conflict is between google-cloud-monitoring==2.0.0 and opencensus-ext-stackdriver.
- appengine/standard_python3/bigquery - data-science-onramp/data-ingestion
- dataflow/encryption-keys - dataflow/flex-templates/streaming_beam
7e765fa
to
6c5c13e
Compare
py-3.6 build has a failure which is likely unrelated to this change. I filed #5247 and restarted the build. |
Another failure. Filed #5248 restarting the build. |
Another flake: |
All green. Merging. |
Please merge for me once this is approved. Thanks!
Related CL: cl/350677556