Skip to content

chore(GAE flex): rm unused memcache sample #5271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

chore(GAE flex): rm unused memcache sample #5271

merged 1 commit into from
Jan 20, 2021

Conversation

ace-n
Copy link

@ace-n ace-n commented Jan 20, 2021

@qchong please LGTM too, thanks!

@ace-n ace-n requested a review from engelke January 20, 2021 21:20
@ace-n ace-n requested a review from a team as a code owner January 20, 2021 21:20
@snippet-bot
Copy link

snippet-bot bot commented Jan 20, 2021

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 20, 2021
@ace-n ace-n requested a review from busunkim96 January 20, 2021 21:20
engelke
engelke approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2021
@ace-n ace-n merged commit 07e34b2 into master Jan 20, 2021
@ace-n ace-n deleted the rm-memcache branch January 20, 2021 23:07
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@engelke engelke engelke approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @engelke @busunkim96 @leahecole