-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: use pytds driver in SQL Server sample #5292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use pytds driver in SQL Server sample #5292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass.
@@ -1,4 +1,5 @@ | |||
Flask==1.1.2 | |||
SQLAlchemy==1.3.22 | |||
pyodbc==4.0.30 | |||
python-tds==1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection_test is still using pyodbc.
The tests are passing locally while running the proxy, but not on Kokoro. Getting this error.
I'm in the process of debugging it. Any ideas why this error would show up here but not locally? |
Are we using the same instance? Is it possible there is a "required SSL" bit that was flipped for overground? |
Different instance, but both are under the Google org so overground rules should be the same. The instance I'm using has private IP enabled, so that might be the difference. Also, shouldn't using the proxy mean the connection to the server is SSL-encrypted? Is the issue that it expects encryption while connecting to the proxy server on the client side too? |
Description
Update sample to use pytds, a pure-python driver instead of pyodbc, so that it can work on Cloud Functions
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)