Skip to content

BigQuery - use new QueryJob.results() method. #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2016
Merged

BigQuery - use new QueryJob.results() method. #555

merged 1 commit into from
Oct 5, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 5, 2016

This method was added in
googleapis/google-cloud-python#2083.
I can remove my hack now.

@tswast
BigQuery - use new QueryJob.results() method.
32d233b 
This method was added in
googleapis/google-cloud-python#2083.
I can remove my hack now.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2016
@tswast
Copy link
Contributor Author

tswast commented Oct 5, 2016

@dpebot Merge when green

@dpebot
Copy link
Collaborator

dpebot commented Oct 5, 2016

Okay! I'll merge when all statuses are green.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2016
@theacodes theacodes merged commit 07e92d7 into master Oct 5, 2016
@theacodes theacodes deleted the tswast-bq branch October 5, 2016 18:25
@theacodes
Copy link
Contributor

I beat @dpebot to it.

plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
@tswast
BigQuery - use new QueryJob.results() method. [(googleapis#555)](Goog…
b3b063a 
…leCloudPlatform/python-docs-samples#555)

This method was added in
googleapis/google-cloud-python#2083.
I can remove my hack now.
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
@tswast @plamut
BigQuery - use new QueryJob.results() method. [(googleapis#555)](Goog…
6ce03fc 
…leCloudPlatform/python-docs-samples#555)

This method was added in
googleapis/google-cloud-python#2083.
I can remove my hack now.
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
@tswast @shollyman
BigQuery - use new QueryJob.results() method. [(#555)](GoogleCloudPla…
f43905b 
…tform/python-docs-samples#555)

This method was added in
googleapis/google-cloud-python#2083.
I can remove my hack now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@theacodes theacodes

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tswast @dpebot @theacodes @googlebot