Skip to content

Google cloud-client compute samples #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

m-strzelczyk
Copy link
Contributor

Description

Adding initial code samples for the google-cloud-compute library.

Checklist

@m-strzelczyk m-strzelczyk requested a review from a team as a code owner May 17, 2021 07:26
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 17, 2021
@snippet-bot
Copy link

snippet-bot bot commented May 17, 2021

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2021
@m-strzelczyk m-strzelczyk changed the title Google cloud compute samples Google cloud-client compute samples May 17, 2021
@busunkim96
Copy link
Contributor

Hey @m-strzelczyk, could you open this PR on https://github.com/googleapis/python-compute? We try to keep library specific samples inside the library repositories. You can copy paste what you have here into a samples/snippets directory.

See https://github.com/googleapis/python-automl/tree/master/samples/snippets for an example.

Thanks!

@rsamborski
Copy link
Member

@busunkim96 can you please clarify your ask on moving the samples to a different repository? We followed the official Code Snippets 101 guide and for all other languages the goto repo is language-docs-samples. Does it mean the docs should be updated?
We would like to be consistent and make sure the samples are in the right place. Thanks for providing more insights.

@busunkim96
Copy link
Contributor

@rsamborski Please see https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#folder-location. Languages with split repositories (NodeJS, Java, and Python) place library specific samples in the library repository.

@m-strzelczyk
Copy link
Contributor Author

Thanks for the clarification. I moved to the python-compute repo and am waiting for the PR to be merged :) googleapis/python-compute#55

I'll close this PR now, as there's nothing to do.

@m-strzelczyk m-strzelczyk deleted the google-cloud-compute-samples branch May 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants