add airflow 1 samples to legacy samples #5896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 34 region tags.
This comment is generated by snippet-bot.
|
b613274 to
8e9bf33
Compare
|
These are moving files previously authored not in 2021 to another directory. Does the copyright year need to be updated? @GoogleCloudPlatform/python-samples-owners |
|
@leahecole unless they're brand new files that need to be stamped, the years should never change on existing license headers. |
They are not! They just moved. I know it looks like their brand new, but they're actually old and are being put into their new home. |
|
If that's the case it'll be fine to leave them as-is :D |
engelke
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the migration from Airflow 1 to Airflow 2, the TWs for Composer, atorin@ and salnikov@, have requested that we make the corresponding Airflow 1 samples available until Airflow is officially EOL in Composer.
This PR moves the Airflow 1 compatible samples from the
composer/workflowsdirectory and their tests/dependencies to their own folder so that when EOL comes, we can justrm -rthe whole directory 😄in order to properly show things in docs though, I had to add a bunch of new region tags. Thanks to snippet bot for helping me make those region tags show up in the docs! ❤️ 🤖 ❤️
Accompanying CL - 376277715
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)