Add support for third-party memcache #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4d4e6e5271f5ec1897f6745d2679e1d9240a450b
broady
reviewed
Oct 20, 2016
| memcache_port = os.environ.get('GAE_MEMCACHE_PORT', 11211) | ||
| memcache_client = MemcacheClient((memcache_addr, int(memcache_port))) | ||
| # Environment variables are defined in app.yaml. | ||
| if os.environ.get('USE_GAE_MEMCACHE'): |
There was a problem hiding this comment.
Why prefer that when the GAE env vars all use the "GAE" initialism?
There was a problem hiding this comment.
they're inconsistent. change this one or the one in app.yaml
There was a problem hiding this comment.
Oh, gotcha. Sorry! Fixed.
| if os.environ.get('USE_GAE_MEMCACHE'): | ||
| MEMCACHE_SERVER = ':'.join( | ||
| os.environ.get('GAE_MEMCACHE_HOST', 'localhost'), | ||
| os.environ.get('GAE_MEMCACHE_PORT', 11211)) |
There was a problem hiding this comment.
why not just check these env vars instead of having a separate env var as a flag?
There was a problem hiding this comment.
Because eventually these will always be set, and I don't want code that's using third-party memcache to suddenly start using GAE memcache.
JustinBeckwith
approved these changes
Oct 20, 2016
| @@ -20,6 +20,6 @@ Start your application: | |||
|
|
|||
| Deploy using `gcloud`: | |||
|
|
|||
| gcloud beta app deploy app.yaml | |||
| gcloud app deploy app.yaml | |||
There was a problem hiding this comment.
Just gcloud app deploy here is fine
added 2 commits
October 20, 2016 15:49
Change-Id: I738e3fa89ccf3814199e3f90c47f463df8ea7f0f
Change-Id: Ic6d7468bb6145c92fe95c8e28d29c0cf6259dbd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @JustinBeckwith
/cc @jmdobry @bshaffer @broady @tmatsuo @lesv @remi