Use unittest.TestCase assertions #614
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@docent-net thanks for the change, but we'll need you to sign the CLA before we can review and merge. Let me know if you have any questions or concerns. |
While inside a class that inherits from unittest.TestCase it makes sense to use provided by TestCase assertion methods instead of pure Python's assertion()
|
CLAs look good, thanks! |
|
@jonparrott ah again - I already signed CLA but pushed changes using non-gmail email address set in repository config. I just amended it and should be fine |
|
LGTM, thank you! |
While inside a class that inherits from unittest.TestCase it makes sense to use provided by TestCase assertion methods instead of pure Python's assertion()