Skip to content

Revert & fix "Revert "Lint session should check all changed files. (#… #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2016
Merged

Revert & fix "Revert "Lint session should check all changed files. (#… #621

merged 2 commits into from
Oct 27, 2016

Conversation

jerjou
Copy link
Contributor

@jerjou jerjou commented Oct 27, 2016

…619)""

This reverts commit ae8dccb.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2016
@jerjou
Copy link
Contributor Author

jerjou commented Oct 27, 2016

(tested manually by running nox -s lint . in a virtualenv)

@jerjou jerjou added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou
Copy link
Contributor Author

jerjou commented Oct 27, 2016

(actually - hold off - I realize my test was a little suspicious.. investigating..)

@theacodes
Copy link
Contributor

I don't think you should run nox -s lint ., nox is supposed to run a separate lint for each sample because of local import names.

@jerjou jerjou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou
Copy link
Contributor Author

jerjou commented Oct 27, 2016

Okay - fixed. Also fixed a bunch of lint errors. PTAL.

@theacodes theacodes merged commit aac0e02 into master Oct 27, 2016
@theacodes theacodes deleted the lint branch October 27, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerjou @theacodes @googlebot