Skip to content

chore: Handle AutoGKE in composer_db_transfer.py #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2021
Merged

chore: Handle AutoGKE in composer_db_transfer.py #6438

merged 5 commits into from
Aug 3, 2021

Conversation

jacek-izykowski
Copy link
Member

@jacek-izykowski jacek-izykowski commented Jul 19, 2021 •
edited by leahecole
Loading

(+ clarify DRS-related messages)

Internal CL with robust tests - 384703580

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

@jacek-izykowski
Handle AutoGKE in composer_db_transfer.py
c19ece8 
(+ clarify DRS-related messages)
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
@parthea parthea changed the title Handle AutoGKE in composer_db_transfer.py chore: Handle AutoGKE in composer_db_transfer.py Jul 30, 2021
@jacek-izykowski jacek-izykowski marked this pull request as ready for review August 1, 2021 21:17
@leahecole
Copy link
Collaborator

Looking for review #2 from @GoogleCloudPlatform/python-samples-owners pretty please - see the comment for the internal CL

dandhlee
dandhlee approved these changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leahecole leahecole merged commit 6305246 into GoogleCloudPlatform:master Aug 3, 2021
@jacek-izykowski jacek-izykowski deleted the db-transfer-with-autko-gke branch August 4, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@dandhlee dandhlee dandhlee approved these changes

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacek-izykowski @leahecole @dandhlee