Skip to content

fix: Encryption samples no logner break with new requests library version #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2021
Merged

fix: Encryption samples no logner break with new requests library version #6464

merged 3 commits into from
Jul 22, 2021

Conversation

m-strzelczyk
Copy link
Contributor

Description

Fixes the code that was failing with new version of requests library, as evident in #6422

Checklist

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 22, 2021
@m-strzelczyk m-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 22, 2021 12:28
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 22, 2021 12:28
@m-strzelczyk m-strzelczyk mentioned this pull request Jul 22, 2021
Merged
1 task
@parthea parthea removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
dandhlee
dandhlee approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you :)

@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e6368a5 into master Jul 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the encryption-fix branch July 22, 2021 16:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-strzelczyk @parthea @dandhlee