chore: clean up django region tags #6495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
dandhlee
reviewed
Jul 29, 2021
| @@ -164,6 +164,7 @@ | |||
|
|
|||
| # Static files (CSS, JavaScript, Images) | |||
| # [START staticurl] | |||
| # [START gaeflex_py_django_static_config] | |||
| # [START gaeflex_py_django_staticconfig] | |||
There was a problem hiding this comment.
does staticconfig tag still need to be here? Or do you plan on removing that in a future PR once static_config region tag fully replaces it?
There was a problem hiding this comment.
it does for now, until I replace it with the new version in the docs, then I can remove it from the sample in another PR
There was a problem hiding this comment.
Sounds good! Thank you for clarifying it.
parthea
approved these changes
Jul 29, 2021
dandhlee
approved these changes
Jul 29, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes old tags, cleans up a newer tag to confirm with format (underscore separated names)
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)