Skip to content

Update composer_storage_trigger.py script to support stable API #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2021
Merged

Update composer_storage_trigger.py script to support stable API #6632

merged 6 commits into from
Sep 1, 2021

Conversation

kosteev
Copy link
Contributor

@kosteev kosteev commented Aug 27, 2021

Description

Fixes #6631

Checklist

Partial run of tests passed.

@kosteev kosteev requested review from leahecole, rachael-ds and a team as code owners August 27, 2021 14:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 27, 2021
@kurtisvg kurtisvg assigned leahecole and unassigned kurtisvg Aug 27, 2021
@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2021
@kosteev kosteev changed the title [DO NOT MERGE UNTIL COMPOSER 1.17.0-preview.12] Update composer_storage_trigger.py script to support stable API Update composer_storage_trigger.py script to support stable API Aug 31, 2021
@kosteev
Copy link
Contributor Author

kosteev commented Aug 31, 2021

This is ready for review and if approved to be merged.
@leahecole Can you, please, take a look.

@leahecole
Copy link
Collaborator

leahecole commented Aug 31, 2021 •
edited
Loading

Hey @kosteev - the experimental API part works great. Working on testing w/ Stable API and have run into some issues. Sent a chat to you and Michał explaining my issue.

(edited - first issue was creating an environment with the stable API. Got that done. Now dealing w/ auth)

@leahecole leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2021
leahecole
leahecole reviewed Sep 1, 2021
View reviewed changes
leahecole
leahecole approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about using the experimental vs stable API and a link to the docs.

Otherwise, now that you unblocked me this morning, this looks great! Thanks for the change!

Googlers, see cl/368290505 for a related docs refresh

dinagraves
dinagraves reviewed Sep 1, 2021
View reviewed changes
leahecole
leahecole reviewed Sep 1, 2021
View reviewed changes
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2021
@leahecole leahecole merged commit 44935b9 into GoogleCloudPlatform:master Sep 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

+1 more reviewer

@dinagraves dinagraves dinagraves approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composer script to trigger DAG doesn't work for stable API
4 participants
@kosteev @leahecole @dinagraves @kurtisvg