fix: create separate bucket for iot gcs_file_to_device test #6732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 24, 2021
busunkim96
commented
Sep 24, 2021
nicain
approved these changes
Sep 27, 2021
1 task
nicain
reviewed
Sep 27, 2021
|
@nicain I've made some additional changes, could you take another look? |
|
@gcseh Please take a look at the IoT test changes when you have a chance. Thank you! |
gcseh
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6725, #6724
I disabled public access on the
python-docs-samples-testsbucket and these were the two tests that failed.For the AppEngine sample it felt a bit awkward to create the bucket before the app is imported (
main.pyreferences the bucket through an env var) so I stood up a new, separate bucket with public access enabled.For IoT, I modified the test to create its own bucket.