Updates to Google ID token service-to-service auth sample #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Nov 21, 2016
| @@ -24,10 +24,9 @@ | |||
| from google.appengine.api import app_identity | |||
| import webapp2 | |||
|
|
|||
| DEFAUTL_SERVICE_ACCOUNT = "YOUR-CLIENT-PROJECT-ID@appspot.gserviceaccount.com" | |||
| SERVICE_ACCOUNT_EMAIL = "YOUR-CLIENT-PROJECT-ID@appspot.gserviceaccount.com" | |||
There was a problem hiding this comment.
I think you can grab this from app_identity: app_identity. get_service_account_name()
There was a problem hiding this comment.
Hi Jon, thanks for the review. I prefer to use a constant SERVICE_ACCOUNT_EMAIL here. This way, the code snippet for filling out payload would look the same for both default service account and non-default service account.
theacodes
approved these changes
Nov 21, 2016
|
@dpebot can you merge when travis is green? |
|
Okay! I'll merge when all statuses are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.