Skip to content

fix(storage): add backoff to retry flaky test #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2021
Merged

fix(storage): add backoff to retry flaky test #6745

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5620fb4
fix(storage): add backoff to retry flaky test
cojenco Sep 27, 2021
a9d5537
Merge branch 'master' into flaky-6736
cojenco Sep 27, 2021
5d0d892
Merge branch 'master' into flaky-6736
leahecole Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions storage/cloud-client/acl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,15 @@ def test_print_bucket_acl_for_user(test_bucket, capsys):
assert "OWNER" in out


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_add_bucket_owner(test_bucket):
storage_add_bucket_owner.add_bucket_owner(test_bucket.name, TEST_EMAIL)

test_bucket.acl.reload()
assert "OWNER" in test_bucket.acl.user(TEST_EMAIL).get_roles()


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_remove_bucket_owner(test_bucket):
test_bucket.acl.user(TEST_EMAIL).grant_owner()
test_bucket.acl.save()
Expand All @@ -103,6 +105,7 @@ def test_remove_bucket_owner(test_bucket):
assert "OWNER" not in test_bucket.acl.user(TEST_EMAIL).get_roles()


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_add_bucket_default_owner(test_bucket):
storage_add_bucket_default_owner.add_bucket_default_owner(
test_bucket.name, TEST_EMAIL
Expand All @@ -113,6 +116,7 @@ def test_add_bucket_default_owner(test_bucket):
assert "OWNER" in roles


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_remove_bucket_default_owner(test_bucket):
test_bucket.acl.user(TEST_EMAIL).grant_owner()
test_bucket.acl.save()
Expand Down Expand Up @@ -146,6 +150,7 @@ def test_print_blob_acl_for_user(test_blob, capsys):
assert "OWNER" in out


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_add_blob_owner(test_blob):
storage_add_file_owner.add_blob_owner(
test_blob.bucket.name, test_blob.name, TEST_EMAIL)
Expand All @@ -154,6 +159,7 @@ def test_add_blob_owner(test_blob):
assert "OWNER" in test_blob.acl.user(TEST_EMAIL).get_roles()


@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def test_remove_blob_owner(test_blob):
test_blob.acl.user(TEST_EMAIL).grant_owner()
test_blob.acl.save()
Expand Down