Update Cloud SQL sample apps with SSL example #6777
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
code LGTM so far, but we should figure out what's going on with the Python 3.10 build. |
cloud-sql/mysql/sqlalchemy/main.py
Outdated
| return init_tcp_connection_engine(db_config) | ||
| if os.environ.get("DB_ROOT_CERT"): | ||
| return init_tcp_sslcerts_connection_engine(db_config) | ||
| else: |
There was a problem hiding this comment.
nit: the else isn't needed here as we return, same for the other else.
There was a problem hiding this comment.
Updated as suggested.
cloud-sql/mysql/sqlalchemy/main.py
Outdated
| # otherwise use DB_PORT environment variable. | ||
| host_args = db_host.split(":") | ||
| if len(host_args) == 1: | ||
| db_hostname = db_host |
There was a problem hiding this comment.
this looked strange to me since we did the split but then didn't use it. Possibly could reduce that out as well
db_hostname = host_args[0] in both parts?
There was a problem hiding this comment.
Updated to use db_hostname = host_args[0] in both parts as suggested.
No description provided.