Skip to content

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Oct 13, 2021

Description

Fixes #6912

  • Adds a comment to the KubernetesPodOperator explaining that pod affinity isn't supported in Composer 2
  • Adds a comment and error handling to the get_client_id utility regarding usage with Composer 2
  • Adds a comment to the trigger_dag cloud function regarding usage with Composer 2 (users will likely use get_client_id before using the trigger_dag function and will get a more detailed error message there. Updating this script will come in a later PR)
  • Adds 3.10 exemption to noxfile config - Composer w/ Airflow 2 (both composer 1 and composer 2) are Python 3.8 only as of now

cc @rafalbiegacz @pavel-salnikov

Note: It's a good idea to open an issue first for discussion.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@leahecole leahecole marked this pull request as ready for review October 20, 2021 17:53
@leahecole leahecole requested review from rachael-ds and a team as code owners October 20, 2021 17:53
@leahecole leahecole changed the title WIP: Small updates to k8s operators for Composer 2 Small updates to samples for Composer v2 Oct 20, 2021
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment below.

@leahecole leahecole requested a review from dandhlee October 20, 2021 20:27
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@leahecole leahecole merged commit 8ea51a5 into master Oct 21, 2021
@leahecole leahecole deleted the k8s-composer2 branch October 21, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments about Pod Affinity in KPO
4 participants