fix: 3.10 build - Remove noxfiles, add noxfile_configs where needed #7077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
approved these changes
Nov 10, 2021
loferris
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in the build were failing because nox failed to find a session. This is because there were still some noxfiles hanging around where there shouldn't have been anymore. I removed them and in cases where the noxfile specified nox version, added a noxfile config.
I added 3.8 back to the pubsub/streaming analytics because I know 3.8 is compatible with Dataflow, but the versions ignored in this noxfile config are the ones that are not
If you want to look at 3.10 builds where the logs are truncated see this tip
Relates to #6902